westonpace commented on a change in pull request #11207:
URL: https://github.com/apache/arrow/pull/11207#discussion_r714333823
##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -221,6 +221,9 @@ class MappingGenerator {
bool should_trigger;
{
auto guard = state->mutex.Lock();
+ // A MappedCallback may have purged or be purging the queue;
+ // we shouldn't do anything here.
+ if (state->finished) return;
Review comment:
You can ignore the third parameter. Odd that the overload doesn't exist
:confused:. It was basically to toggle between a newly added
BasicMappingGenerator (which pulls from source reentrantly) and the regular
mapping generator (which does not pull from the source reentrantly but does
allow the map function to run in parallel). I think the test is always using
`true` which maps to what we currently have. So just drop the `true` and you
should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
