lidavidm commented on a change in pull request #11210:
URL: https://github.com/apache/arrow/pull/11210#discussion_r714774458
##########
File path: cpp/src/arrow/compute/exec/filter_node.cc
##########
@@ -99,11 +105,35 @@ class FilterNode : public ExecNode {
void InputReceived(ExecNode* input, ExecBatch batch) override {
DCHECK_EQ(input, inputs_[0]);
- auto maybe_filtered = DoFilter(std::move(batch));
- if (ErrorIfNotOk(maybe_filtered.status())) return;
+ ARROW_LOG(DEBUG) << "FilterNode: >> input";
+
+ auto executor = plan()->exec_context()->executor();
Review comment:
While that's currently true, I think we want to require an executor in
the future (even if the executor is "block and do the work on the calling
thread"). See https://github.com/apache/arrow/pull/10845#issuecomment-904986082
and ARROW-13741.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
