lidavidm commented on a change in pull request #11210:
URL: https://github.com/apache/arrow/pull/11210#discussion_r714779047
##########
File path: cpp/src/arrow/compute/exec/filter_node.cc
##########
@@ -113,7 +131,22 @@ class FilterNode : public ExecNode {
void InputFinished(ExecNode* input, int total_batches) override {
DCHECK_EQ(input, inputs_[0]);
+ auto executor = plan()->exec_context()->executor();
+
+ for (auto&& task : tasks_) {
Review comment:
InputFinished (despite its name) can be called before InputReceived
(it's less of an "input is done" and more of "this is how many inputs to
expect"). So this won't necessarily work; you'll want something like the
AtomicCounter pattern used in other exec nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
