lidavidm commented on a change in pull request #11218:
URL: https://github.com/apache/arrow/pull/11218#discussion_r715031524
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.cc
##########
@@ -158,26 +180,73 @@ std::shared_ptr<DataType> CommonNumeric(const ValueDescr*
begin, size_t count) {
return int8();
}
-std::shared_ptr<DataType> CommonTimestamp(const std::vector<ValueDescr>&
descrs) {
+Status CheckCommonParameters(const ValueDescr* begin, size_t count) {
Review comment:
Much of this will need to be reconciled with ARROW-13390/#11080.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
