lidavidm commented on a change in pull request #11218:
URL: https://github.com/apache/arrow/pull/11218#discussion_r719605721
##########
File path: cpp/src/arrow/compute/kernels/scalar_if_else_test.cc
##########
@@ -103,7 +118,7 @@ void CheckWithDifferentShapes(const std::shared_ptr<Array>&
cond,
auto len = left->length();
enum { COND_SCALAR = 1, LEFT_SCALAR = 2, RIGHT_SCALAR = 4 };
- for (int mask = 0; mask < (COND_SCALAR | LEFT_SCALAR | RIGHT_SCALAR);
++mask) {
+ for (int mask = 1; mask <= (COND_SCALAR | LEFT_SCALAR | RIGHT_SCALAR);
++mask) {
for (int64_t cond_idx = 0; cond_idx < len; ++cond_idx) {
Review comment:
Thanks, this makes things much more readable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
