alamb commented on a change in pull request #809:
URL: https://github.com/apache/arrow-rs/pull/809#discussion_r717046050
##########
File path: arrow/src/buffer/mod.rs
##########
@@ -23,7 +23,7 @@ pub use immutable::*;
mod mutable;
pub use mutable::*;
mod ops;
-pub(super) use ops::*;
+pub use ops::*;
Review comment:
>So it seems like there is a bigger discussion here of what is necessary
to make it feasible for the user to write kernels operating on buffers. The
reason I want to make it public, is that it is the minimum change (since the
generic implementation of nullif is tied up in discussion) that enables writing
that within my project, given the problems with the Buffer interface.
Your description makes sense, and to be honest I am fine with merging this
change (though I would like some other perspectives before doing so).
I think something that injects some uncertainty into this discussion is what
the timeframe for integrating some of the changes that are in arrow2 (which
among other things I think basically replaces `Buffer` with an alternate
implementation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
