jhorstmann commented on a change in pull request #809:
URL: https://github.com/apache/arrow-rs/pull/809#discussion_r717085174
##########
File path: arrow/src/buffer/mod.rs
##########
@@ -23,7 +23,7 @@ pub use immutable::*;
mod mutable;
pub use mutable::*;
mod ops;
-pub(super) use ops::*;
+pub use ops::*;
Review comment:
Using these helpers outside of arrow would be useful, I had a similar
usecase before but worked around it with bit_slice and a less optimized
implementation. I would much prefer if we had a better abstraction for bitmap
and offset related logic, like in arrow2. Not sure if a big refactoring is
worth it if there is a potential switch to arrow2 in the future. On the other
hand a big-bang switch to arrow2 seems a bit scary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
