westonpace commented on a change in pull request #10955:
URL: https://github.com/apache/arrow/pull/10955#discussion_r717485780
##########
File path: cpp/src/arrow/dataset/file_base.cc
##########
@@ -115,7 +110,7 @@ Result<std::shared_ptr<FileFragment>>
FileFormat::MakeFragment(
}
// TODO(ARROW-12355[CSV], ARROW-11772[IPC], ARROW-11843[Parquet]) The following
Review comment:
I updated the comment. Making it pure virtual failed because of some
test utilities (DummyFileFormat / JSONRecordBatchFormat) but, more
significantly, I think this is being used by the PR to add ORC support to
datasets (#10991).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
