westonpace commented on a change in pull request #10955:
URL: https://github.com/apache/arrow/pull/10955#discussion_r718114384
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -3295,8 +3295,8 @@ def test_write_dataset_with_scanner(tempdir):
dataset = ds.dataset(tempdir, partitioning=["b"])
with tempfile.TemporaryDirectory() as tempdir2:
- ds.write_dataset(dataset.scanner(columns=["b", "c"]), tempdir2,
- format='parquet', partitioning=["b"])
+ ds.write_dataset(dataset.scanner(columns=["b", "c"], use_async=True),
Review comment:
Yes. I'm hoping most users are not creating scanners directly so this
change should be fairly smooth.
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -3656,16 +3650,12 @@ def file_visitor(written_file):
# Since it is a multi-threaded write there is no way to know which
# directory gets part-0 and which gets part-1
- expected_paths_a = {
+ expected_paths = {
Review comment:
Good catch. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
