coryan commented on a change in pull request #11331:
URL: https://github.com/apache/arrow/pull/11331#discussion_r724437957
##########
File path: cpp/CMakeLists.txt
##########
@@ -801,7 +801,11 @@ endif()
set(ARROW_SHARED_PRIVATE_LINK_LIBS ${ARROW_STATIC_LINK_LIBS})
# boost::filesystem is needed for S3 and Flight tests as a boost::process
dependency.
-if(((ARROW_FLIGHT OR ARROW_S3) AND (ARROW_BUILD_TESTS OR
ARROW_BUILD_INTEGRATION)))
+if(((ARROW_FLIGHT
+ OR ARROW_S3
Review comment:
I do not think is this change, as the build has `-DARROW_GCS=OFF`:
https://github.com/apache/arrow/pull/11331/checks?check_run_id=3830637295#step:9:62
and the change is (modulo reformatting) changing `(ARROW_FLIGHT OR
ARROW_S3)` to `(ARROW_FLIGHT OR ARROW_S3 OR ARROW_GCS)`. In addition, this
change has been there since the first commit in the branch.
At a guess this is either a transient or the point in `master` where I based
the branch has a problem, I can rebase if you think that would help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
