coryan commented on a change in pull request #11331:
URL: https://github.com/apache/arrow/pull/11331#discussion_r725291547
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3704,6 +3706,13 @@ endmacro()
if(ARROW_WITH_GOOGLE_CLOUD_CPP)
resolve_dependency(google_cloud_cpp_storage)
+ include_directories(SYSTEM ${GOOGLE_CLOUD_CPP_INCLUDE_DIR})
+ get_target_property(absl_base_INCLUDE_DIR absl::base
INTERFACE_INCLUDE_DIRECTORIES)
+ include_directories(SYSTEM ${absl_base_INCLUDE_DIR})
+ message(STATUS "Found google-cloud-cpp::storage static library:
${GOOGLE_CLOUD_CPP_STATIC_LIBRARY_STORAGE}"
+ )
+ message(STATUS "Found google-cloud-cpp::storage headers:
${GOOGLE_CLOUD_CPP_INCLUDE_DIR}"
+ )
Review comment:
Ack. In case it helps, it might be this:
https://github.com/apache/arrow/blob/00c27417a754befc2c6efc8ecef8505439400df1/cpp/cmake_modules/BuildUtils.cmake#L285-L287
the `arrow_objlib` target does not seem to link any dependencies, so when
its object files are compiled, none of the required flags are set. You may
want to add the dependencies to `arrow_objlib` and then things should "Just
Work":tm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
