emkornfield commented on a change in pull request #11375:
URL: https://github.com/apache/arrow/pull/11375#discussion_r725703135
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -35,19 +68,85 @@ google::cloud::Options AsGoogleCloudOptions(const
GcsOptions& o) {
if (!o.endpoint_override.empty()) {
std::string scheme = o.scheme;
if (scheme.empty()) scheme = "https";
+ if (scheme == "https") {
+ options.set<google::cloud::UnifiedCredentialsOption>(
+ google::cloud::MakeGoogleDefaultCredentials());
+ } else {
+ options.set<google::cloud::UnifiedCredentialsOption>(
+ google::cloud::MakeInsecureCredentials());
+ }
options.set<gcs::RestEndpointOption>(scheme + "://" + o.endpoint_override);
}
return options;
}
+Status ToArrowStatus(google::cloud::Status const& s) {
Review comment:
there should probably be more detailed unit tests for this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
