emkornfield commented on a change in pull request #11375:
URL: https://github.com/apache/arrow/pull/11375#discussion_r725703311
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -35,19 +68,85 @@ google::cloud::Options AsGoogleCloudOptions(const
GcsOptions& o) {
if (!o.endpoint_override.empty()) {
std::string scheme = o.scheme;
if (scheme.empty()) scheme = "https";
+ if (scheme == "https") {
+ options.set<google::cloud::UnifiedCredentialsOption>(
+ google::cloud::MakeGoogleDefaultCredentials());
+ } else {
+ options.set<google::cloud::UnifiedCredentialsOption>(
+ google::cloud::MakeInsecureCredentials());
+ }
options.set<gcs::RestEndpointOption>(scheme + "://" + o.endpoint_override);
}
return options;
}
+Status ToArrowStatus(google::cloud::Status const& s) {
+ std::ostringstream os;
+ os << "google::cloud::Status(" << s << ")";
+ switch (s.code()) {
+ case google::cloud::StatusCode::kOk:
+ break;
+ case google::cloud::StatusCode::kCancelled:
+ return Status::Cancelled(os.str());
+ case google::cloud::StatusCode::kUnknown:
+ return Status::UnknownError(os.str());
+ case google::cloud::StatusCode::kInvalidArgument:
+ return Status::Invalid(os.str());
+ case google::cloud::StatusCode::kDeadlineExceeded:
+ case google::cloud::StatusCode::kNotFound:
+ // TODO: it is unclear if a better mapping would be possible.
+ return Status::UnknownError(os.str());
+ case google::cloud::StatusCode::kAlreadyExists:
+ return Status::AlreadyExists(os.str());
+ case google::cloud::StatusCode::kPermissionDenied:
+ case google::cloud::StatusCode::kUnauthenticated:
+ return Status::UnknownError(os.str());
+ case google::cloud::StatusCode::kResourceExhausted:
+ return Status::CapacityError(os.str());
+ case google::cloud::StatusCode::kFailedPrecondition:
+ case google::cloud::StatusCode::kAborted:
+ return Status::UnknownError(os.str());
+ case google::cloud::StatusCode::kOutOfRange:
+ return Status::Invalid(os.str());
+ case google::cloud::StatusCode::kUnimplemented:
+ return Status::NotImplemented(os.str());
+ case google::cloud::StatusCode::kInternal:
+ case google::cloud::StatusCode::kUnavailable:
+ case google::cloud::StatusCode::kDataLoss:
+ return Status::UnknownError(os.str());
+ }
+ return Status::OK();
+}
+
class GcsFileSystem::Impl {
public:
explicit Impl(GcsOptions o)
: options_(std::move(o)), client_(AsGoogleCloudOptions(options_)) {}
GcsOptions const& options() const { return options_; }
+ Result<FileInfo> GetFileInfo(GcsPath const& path) {
+ if (!path.object.empty()) {
+ auto meta = client_.GetObjectMetadata(path.bucket, path.object);
+ return GetFileInfoImpl(path, std::move(meta).status(), FileType::File);
+ }
+ auto meta = client_.GetBucketMetadata(path.bucket);
+ return GetFileInfoImpl(path, std::move(meta).status(),
FileType::Directory);
+ }
+
private:
+ Result<FileInfo> GetFileInfoImpl(GcsPath const& path, google::cloud::Status
status,
Review comment:
should status be passed with const ref?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
