nealrichardson commented on a change in pull request #11315:
URL: https://github.com/apache/arrow/pull/11315#discussion_r728404410
##########
File path: r/R/table.R
##########
@@ -141,20 +144,6 @@ Table <- R6Class("Table",
num_columns = function() Table__num_columns(self),
num_rows = function() Table__num_rows(self),
schema = function() Table__schema(self),
- metadata = function(new) {
- if (missing(new)) {
- # Get the metadata (from the schema)
- self$schema$metadata
- } else {
- # Set the metadata
- new <- prepare_key_value_metadata(new)
- out <- Table__ReplaceSchemaMetadata(self, new)
- # ReplaceSchemaMetadata returns a new object but we're modifying in
place,
- # so swap in that new C++ object pointer into our R6 object
- self$set_pointer(out$pointer())
- self
- }
- },
Review comment:
Correct, I factored out the ReplaceSchemaMetadata piece that was
different between Table and RecordBatch (bc static typing) and then moved the
method to ArrowTabular
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
