edponce commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r728486708
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -3038,23 +3062,17 @@ const FunctionDoc extract_regex_doc(
void AddExtractRegex(FunctionRegistry* registry) {
auto func = std::make_shared<ScalarFunction>("extract_regex", Arity::Unary(),
&extract_regex_doc);
- using t32 = ExtractRegex<StringType>;
- using t64 = ExtractRegex<LargeStringType>;
OutputType out_ty(ResolveExtractRegexOutput);
- ScalarKernel kernel;
-
- // Null values will be computed based on regex match or not
- kernel.null_handling = NullHandling::COMPUTED_NO_PREALLOCATE;
- kernel.mem_allocation = MemAllocation::NO_PREALLOCATE;
- kernel.signature.reset(new KernelSignature({utf8()}, out_ty));
- kernel.exec = t32::Exec;
- kernel.init = t32::State::Init;
- DCHECK_OK(func->AddKernel(kernel));
- kernel.signature.reset(new KernelSignature({large_utf8()}, out_ty));
- kernel.exec = t64::Exec;
- kernel.init = t64::State::Init;
- DCHECK_OK(func->AddKernel(kernel));
-
+ for (const auto& ty : StringTypes()) {
Review comment:
Yes, current state of PR does not includes `extract_regex` but this
change will be made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
