edponce commented on a change in pull request #11233:
URL: https://github.com/apache/arrow/pull/11233#discussion_r728492684
##########
File path: cpp/src/arrow/testing/gtest_util.h
##########
@@ -175,6 +175,8 @@ using TemporalArrowTypes =
using DecimalArrowTypes = ::testing::Types<Decimal128Type, Decimal256Type>;
+using BinaryBaseArrowTypes = ::testing::Types<BinaryType, LargeBinaryType>;
+
Review comment:
I agree. The issue was is that `BinaryArrowTypes` includes both `Binary`
and `String`, so maybe `BinaryOnly` would be a better name.
##########
File path: cpp/src/arrow/testing/gtest_util.h
##########
@@ -175,6 +175,8 @@ using TemporalArrowTypes =
using DecimalArrowTypes = ::testing::Types<Decimal128Type, Decimal256Type>;
+using BinaryBaseArrowTypes = ::testing::Types<BinaryType, LargeBinaryType>;
+
Review comment:
I agree. The issue is that `BinaryArrowTypes` includes both `Binary` and
`String`, so maybe `BinaryOnly` would be a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
