dragosmg commented on a change in pull request #11417:
URL: https://github.com/apache/arrow/pull/11417#discussion_r728845173
##########
File path: r/tests/testthat/test-dplyr-funcs-conditional.R
##########
@@ -268,14 +268,15 @@ test_that("case_when()", {
collect(),
tbl
)
- skip("ARROW-13799: factor() should error but instead we get a string error
message in its place")
+ # skip("ARROW-13799: factor() should error but instead we get a string error
message in its place")
Review comment:
Technically this PR solves the ARROW-13799 issue. It's not an issue with
`factor()` (which we haven't implemented yet). A separate issue for
`as.factor()` exists (ARROW-12632). I think the comment can simply be deleted.
I've also replaced `warning = "case_when"` with `warning = TRUE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
