jonkeane commented on a change in pull request #11417:
URL: https://github.com/apache/arrow/pull/11417#discussion_r729053722
##########
File path: r/R/dplyr-functions.R
##########
@@ -915,6 +915,9 @@ nse_funcs$case_when <- function(...) {
if (!nse_funcs$is.logical(query[[i]])) {
abort("Left side of each formula in case_when() must be a logical
expression")
}
+ if (inherits(value[[i]], "try-error")) {
+ abort("There is an error in the right side of the case_when() formula")
Review comment:
This is minor, but I wonder if it should be phrased to match the error
above:
"Right side of formula raised an error: " and then also include that
`value[[i]]` so that someone could see what the problem was
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
