cyb70289 commented on a change in pull request #11456:
URL: https://github.com/apache/arrow/pull/11456#discussion_r731590208



##########
File path: python/CMakeLists.txt
##########
@@ -103,9 +103,21 @@ set(BUILD_WARNING_LEVEL "PRODUCTION")
 
 # This must be synchronized with the definition in
 # cpp/cmake_modules/DefineOptions.cmake.
-set(ARROW_ARMV8_ARCH
-    "armv8-a"
-    CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or 
armv8-a+crc+crypto")
+if(NOT DEFINED ARROW_SIMD_LEVEL)
+  set(ARROW_SIMD_LEVEL
+      "DEFAULT"
+      CACHE STRING "Compile time SIMD optimization level")
+endif()

Review comment:
       `ARROW_SIMD_LEVEL` variable is empty if we don't set it here explicitly, 
same as passing `-DARROW_SIMD_LEVEL=`. It disables simd silently when building 
cpp files under python dir.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to