thisisnic commented on a change in pull request #11403:
URL: https://github.com/apache/arrow/pull/11403#discussion_r731601929
##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -64,24 +65,31 @@ verify_output <- function(...) {
testthat::verify_output(...)
}
-#' @param expr A dplyr pipeline with `input` as its start
-#' @param tbl A tbl/df as reference, will make RB/Table with
-#' @param skip_record_batch string skip message, if should skip RB test
-#' @param skip_table string skip message, if should skip Table test
-#' @param warning string expected warning from the RecordBatch and Table paths,
+#' Compare dplyr binding
Review comment:
Maybe some explanation would clarify things here. Binding, from the
word bind, as in to tie things together. We've bound the Arrow C++ functions
to other libraries' function names (via `nse_funcs`and the function maps).
These tests are technically used for implementations of methods (e.g.
`arrow::mutate_dplyr_query()`) which aren't quite bindings, but perhaps close
enough.
I was wanting to avoid terms like "expression" just as we have Expression
objects which relate to Arrow Expressions and I think this would potentially
lead to additional confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
