Dandandan commented on a change in pull request #1183:
URL: https://github.com/apache/arrow-datafusion/pull/1183#discussion_r739082628



##########
File path: datafusion/src/execution/context.rs
##########
@@ -176,6 +176,7 @@ impl ExecutionContext {
                 config,
                 execution_props: ExecutionProps::new(),
                 object_store_registry: Arc::new(ObjectStoreRegistry::new()),
+                has_optimized: false,

Review comment:
       What could be done to avoid optimizing a logical plan twice is adding a 
`is_optimized` or something similar to `LogicalPlan` instead. After optimizing 
we can set `is_optimized` to true on the logical plan of the dataframe.
   
   Might also be good to have some numbers about how much time a typical full 
optimization pass costs (and / or to track some statistics) - I would expect in 
most cases it will be quite a bit less than say 1 ms.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to