Dandandan commented on pull request #1183: URL: https://github.com/apache/arrow-datafusion/pull/1183#issuecomment-955168730
> > A summary of what the PR will do. > > I think it might be ok to optimize the plan twice (in other words, perhaps we can close the ticket as "working as expected"?). Do we have any examples of the double optimization causing problems (or taking overly long)? > > I think @Dandandan was also hinting at this point in his comment at https://github.com/apache/arrow-datafusion/pull/1183#discussion_r739082628 > > Adding a lot of additional code to LogicalPlan (`is_optimized` on every variant) seems like it will be a very large change without much benefit, though perhaps I am overlooking potential benefits Yes I was hinting at that. If we are able to show otherwise (examples of logical plan optimization takes very long) then we can see if we can optimize for this case. Otherwise I agree "working as expected" should be the conclusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
