vvellanki commented on a change in pull request #11515: URL: https://github.com/apache/arrow/pull/11515#discussion_r741003304
########## File path: cpp/src/gandiva/encrypt_utils.cc ########## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "encrypt_utils.h" + +#include "gandiva/gdv_function_stubs.h" + +namespace gandiva { + +int32_t aes_encrypt(int64_t context, unsigned char* plaintext, int32_t plaintext_len, Review comment: This is going to perform poorly. This function is called for each and every row in the query. This has too much overhead - please talk to Projjal about how to implement this correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
