vvellanki commented on a change in pull request #11515: URL: https://github.com/apache/arrow/pull/11515#discussion_r741278532
########## File path: cpp/src/gandiva/function_registry_encrypt.cc ########## @@ -0,0 +1,35 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "function_registry_encrypt.h" +#include "gandiva/function_registry_common.h" + +namespace gandiva { + +std::vector<NativeFunction> GetEncryptFunctionRegistry() { + static std::vector<NativeFunction> encrypt_fn_registry_ = { + NativeFunction("aes_encrypt", {}, DataTypeVector{utf8(), utf8()}, utf8(), + kResultNullIfNull, "gdv_fn_aes_encrypt", + NativeFunction::kNeedsContext), Review comment: The implementation of these functions does not use context. Why is this function marked as kNeedsContext? ########## File path: cpp/src/gandiva/encrypt_utils_test.cc ########## @@ -0,0 +1,63 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "gandiva/encrypt_utils.h" + +#include <gtest/gtest.h> + +#include <unordered_set> + +#include "gandiva/execution_context.h" + +TEST(TestShaEncryptUtils, TestAesEncryptDecrypt) { + gandiva::ExecutionContext ctx; + auto ctx_ptr = reinterpret_cast<int64_t>(&ctx); + + auto* key = (unsigned char*)"12345abcde"; Review comment: Can you test with large key lengths? Please add test cases with 16, 32, 64, 128, 192, and 256 byte keys ########## File path: cpp/src/gandiva/encrypt_utils.cc ########## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "encrypt_utils.h" + +#include "gandiva/gdv_function_stubs.h" + +namespace gandiva { + +int32_t aes_encrypt(int64_t context, unsigned char* plaintext, int32_t plaintext_len, Review comment: This is ok for now ########## File path: cpp/src/gandiva/gdv_function_stubs.cc ########## @@ -794,6 +796,60 @@ const char* gdv_fn_initcap_utf8(int64_t context, const char* data, int32_t data_ *out_len = out_idx; return out; } + +GANDIVA_EXPORT +const char* gdv_fn_aes_encrypt(int64_t context, const char* data, int32_t data_len, + const char* key_data, int32_t key_data_len, + int32_t* out_len) { + if (data_len < 0) { + gdv_fn_context_set_error_msg(context, "Invalid data length to be encrypted"); + *out_len = 0; + return ""; + } + + unsigned char encrypted[256]; Review comment: Why do we need this temporary buffer? Why not allocate memory first and pass a pointer to that buffer to aes_encrypt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
