zeroshade commented on a change in pull request #11359: URL: https://github.com/apache/arrow/pull/11359#discussion_r741441847
########## File path: go/arrow/array/util_test.go ########## @@ -0,0 +1,406 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package array_test + +import ( + "bytes" + "fmt" + "io" + "reflect" + "strings" + "testing" + + "github.com/apache/arrow/go/arrow" + "github.com/apache/arrow/go/arrow/array" + "github.com/apache/arrow/go/arrow/decimal128" + "github.com/apache/arrow/go/arrow/internal/arrdata" + "github.com/apache/arrow/go/arrow/memory" + "github.com/goccy/go-json" + "github.com/stretchr/testify/assert" +) + +var typemap = map[arrow.DataType]reflect.Type{ + arrow.PrimitiveTypes.Int8: reflect.TypeOf(int8(0)), + arrow.PrimitiveTypes.Uint8: reflect.TypeOf(uint8(0)), + arrow.PrimitiveTypes.Int16: reflect.TypeOf(int16(0)), + arrow.PrimitiveTypes.Uint16: reflect.TypeOf(uint16(0)), + arrow.PrimitiveTypes.Int32: reflect.TypeOf(int32(0)), + arrow.PrimitiveTypes.Uint32: reflect.TypeOf(uint32(0)), + arrow.PrimitiveTypes.Int64: reflect.TypeOf(int64(0)), + arrow.PrimitiveTypes.Uint64: reflect.TypeOf(uint64(0)), +} + +func TestIntegerArrsJSON(t *testing.T) { + const N = 10 + types := []arrow.DataType{ + arrow.PrimitiveTypes.Int8, + arrow.PrimitiveTypes.Uint8, + arrow.PrimitiveTypes.Int16, + arrow.PrimitiveTypes.Uint16, + arrow.PrimitiveTypes.Int32, + arrow.PrimitiveTypes.Uint32, + arrow.PrimitiveTypes.Int64, + arrow.PrimitiveTypes.Uint64, + } + + for _, tt := range types { + t.Run(fmt.Sprint(tt), func(t *testing.T) { + mem := memory.NewCheckedAllocator(memory.NewGoAllocator()) + defer mem.AssertSize(t, 0) + + jsontest := make([]int, N) + vals := reflect.MakeSlice(reflect.SliceOf(typemap[tt]), N, N) + for i := 0; i < N; i++ { + vals.Index(i).Set(reflect.ValueOf(i).Convert(typemap[tt])) + jsontest[i] = i + } + + data, _ := json.Marshal(jsontest) + arr, _, err := array.FromJSON(mem, tt, bytes.NewReader(data)) + assert.NoError(t, err) + defer arr.Release() + + assert.EqualValues(t, N, arr.Len()) + assert.Zero(t, arr.NullN()) + + output, err := json.Marshal(arr) + assert.NoError(t, err) + assert.JSONEq(t, string(data), string(output)) + }) + t.Run(fmt.Sprint(tt)+" errors", func(t *testing.T) { + _, _, err := array.FromJSON(memory.DefaultAllocator, tt, strings.NewReader("")) + assert.Error(t, err) + + _, _, err = array.FromJSON(memory.DefaultAllocator, tt, strings.NewReader("[")) + assert.ErrorIs(t, err, io.ErrUnexpectedEOF) + + _, _, err = array.FromJSON(memory.DefaultAllocator, tt, strings.NewReader("0")) + assert.Error(t, err) + + _, _, err = array.FromJSON(memory.DefaultAllocator, tt, strings.NewReader("{}")) + assert.Error(t, err) + + _, _, err = array.FromJSON(memory.DefaultAllocator, tt, strings.NewReader("[[0]]")) + assert.EqualError(t, err, "json: cannot unmarshal [ into Go value of type "+tt.Name()) + }) + } +} + +func TestStringsJSON(t *testing.T) { + tests := []struct { + jsonstring string + values []string + valids []bool + }{ + {"[]", []string{}, []bool{}}, + {`["", "foo"]`, []string{"", "foo"}, nil}, + {`["", null]`, []string{"", ""}, []bool{true, false}}, + // NUL character in string + {`["", "some\u0000char"]`, []string{"", "some\x00char"}, nil}, + // utf8 sequence in string + {"[\"\xc3\xa9\"]", []string{"\xc3\xa9"}, nil}, + // bytes < 0x20 can be represented as JSON unicode escapes + {`["\u0000\u001f"]`, []string{"\x00\x1f"}, nil}, + } + + for _, tt := range tests { + t.Run("json "+tt.jsonstring, func(t *testing.T) { + bldr := array.NewStringBuilder(memory.DefaultAllocator) + defer bldr.Release() + + bldr.AppendValues(tt.values, tt.valids) + expected := bldr.NewStringArray() + defer expected.Release() + + arr, _, err := array.FromJSON(memory.DefaultAllocator, arrow.BinaryTypes.String, strings.NewReader(tt.jsonstring)) + assert.NoError(t, err) + defer arr.Release() + + assert.Truef(t, array.ArrayEqual(expected, arr), "expected: %s\ngot: %s\n", expected, arr) + + data, err := json.Marshal(arr) + assert.NoError(t, err) + assert.JSONEq(t, tt.jsonstring, string(data)) + }) + } + + t.Run("errors", func(t *testing.T) { + _, _, err := array.FromJSON(memory.DefaultAllocator, arrow.BinaryTypes.String, strings.NewReader("[0]")) + assert.Error(t, err) + + _, _, err = array.FromJSON(memory.DefaultAllocator, arrow.BinaryTypes.String, strings.NewReader("[[]]")) + assert.Error(t, err) + }) +} + +func TestStructArrayFromJSON(t *testing.T) { + mem := memory.NewCheckedAllocator(memory.NewGoAllocator()) + defer mem.AssertSize(t, 0) + + jsonStr := `[{"hello": 3.5, "world": true, "yo": "foo"},{"hello": 3.25, "world": false, "yo": "bar"}]` + + arr, _, err := array.FromJSON(mem, arrow.StructOf( + arrow.Field{Name: "hello", Type: arrow.PrimitiveTypes.Float64}, + arrow.Field{Name: "world", Type: arrow.FixedWidthTypes.Boolean}, + arrow.Field{Name: "yo", Type: arrow.BinaryTypes.String}, + ), strings.NewReader(jsonStr)) + assert.NoError(t, err) + defer arr.Release() + + output, err := json.Marshal(arr) + assert.NoError(t, err) + assert.JSONEq(t, jsonStr, string(output)) +} + +func TestArrayFromJSONMulti(t *testing.T) { + arr, _, err := array.FromJSON(memory.DefaultAllocator, arrow.StructOf( + arrow.Field{Name: "hello", Type: arrow.PrimitiveTypes.Float64}, + arrow.Field{Name: "world", Type: arrow.FixedWidthTypes.Boolean}, + arrow.Field{Name: "yo", Type: arrow.BinaryTypes.String}, + ), strings.NewReader("{\"hello\": 3.5, \"world\": true, \"yo\": \"foo\"}\n{\"hello\": 3.25, \"world\": false, \"yo\": \"bar\"}\n"), + array.WithMultipleDocs()) + assert.NoError(t, err) + defer arr.Release() + + assert.EqualValues(t, 2, arr.Len()) + assert.Zero(t, arr.NullN()) +} + +func TestNestedJSONArrs(t *testing.T) { + mem := memory.NewCheckedAllocator(memory.NewGoAllocator()) + defer mem.AssertSize(t, 0) + + jsonStr := `[{"hello": 1.5, "world": [1, 2, 3, 4], "yo": [{"foo": "2005-05-06", "bar": "15:02:04.123"},{"foo": "1956-01-02", "bar": "02:10:00"}]}]` + + arr, _, err := array.FromJSON(mem, arrow.StructOf( + arrow.Field{Name: "hello", Type: arrow.PrimitiveTypes.Float64}, + arrow.Field{Name: "world", Type: arrow.ListOf(arrow.PrimitiveTypes.Int32)}, + arrow.Field{Name: "yo", Type: arrow.FixedSizeListOf(2, arrow.StructOf( + arrow.Field{Name: "foo", Type: arrow.FixedWidthTypes.Date32}, + arrow.Field{Name: "bar", Type: arrow.FixedWidthTypes.Time32ms}, + ))}, + ), strings.NewReader(jsonStr)) + defer arr.Release() + assert.NoError(t, err) + + v, err := json.Marshal(arr) + assert.NoError(t, err) + assert.JSONEq(t, jsonStr, string(v)) +} + +func TestGetNullsFromJSON(t *testing.T) { + mem := memory.NewCheckedAllocator(memory.NewGoAllocator()) + defer mem.AssertSize(t, 0) + + jsonStr := `[ + {"yo": "thing", "arr": null, "nuf": {"ps": "今日は"}}, + {"yo": null, "nuf": {"ps": null}, "arr": []}, + { "nuf": null, "yo": "今日は", "arr": [1,2,3]} + ]` + + rec, _, err := array.RecordFromJSON(mem, arrow.NewSchema([]arrow.Field{ + {Name: "yo", Type: arrow.BinaryTypes.String, Nullable: true}, + {Name: "arr", Type: arrow.ListOf(arrow.PrimitiveTypes.Int32), Nullable: true}, + {Name: "nuf", Type: arrow.StructOf(arrow.Field{Name: "ps", Type: arrow.BinaryTypes.String, Nullable: true}), Nullable: true}, + }, nil), strings.NewReader(jsonStr)) + assert.NoError(t, err) + defer rec.Release() + + assert.EqualValues(t, 3, rec.NumCols()) + assert.EqualValues(t, 3, rec.NumRows()) + + data, err := json.Marshal(rec) + assert.NoError(t, err) + assert.JSONEq(t, jsonStr, string(data)) +} + +func TestTimestampsJSON(t *testing.T) { + tests := []struct { + unit arrow.TimeUnit + jsonstr string + values []arrow.Timestamp + }{ + {arrow.Second, `["1970-01-01", "2000-02-29", "3989-07-14", "1900-02-28"]`, []arrow.Timestamp{0, 951782400, 63730281600, -2203977600}}, + {arrow.Nanosecond, `["1970-01-01", "2000-02-29", "1900-02-28"]`, []arrow.Timestamp{0, 951782400000000000, -2203977600000000000}}, + } + + for _, tt := range tests { + dtype := &arrow.TimestampType{Unit: tt.unit} + bldr := array.NewTimestampBuilder(memory.DefaultAllocator, dtype) + defer bldr.Release() + + bldr.AppendValues(tt.values, nil) + expected := bldr.NewArray() + defer expected.Release() + + arr, _, err := array.FromJSON(memory.DefaultAllocator, dtype, strings.NewReader(tt.jsonstr)) + assert.NoError(t, err) + defer arr.Release() + + assert.Truef(t, array.ArrayEqual(expected, arr), "expected: %s\ngot: %s\n", expected, arr) + } +} + +func TestDateJSON(t *testing.T) { + t.Run("date32", func(t *testing.T) { + bldr := array.NewDate32Builder(memory.DefaultAllocator) + defer bldr.Release() + + jsonstr := `["1970-01-06", null, "1970-02-12"]` + + bldr.AppendValues([]arrow.Date32{5, 0, 42}, []bool{true, false, true}) + expected := bldr.NewArray() + defer expected.Release() + + arr, _, err := array.FromJSON(memory.DefaultAllocator, arrow.FixedWidthTypes.Date32, strings.NewReader(jsonstr)) + assert.NoError(t, err) + defer arr.Release() + + assert.Truef(t, array.ArrayEqual(expected, arr), "expected: %s\ngot: %s\n", expected, arr) + + data, err := json.Marshal(arr) + assert.NoError(t, err) + assert.JSONEq(t, jsonstr, string(data)) + }) + t.Run("date64", func(t *testing.T) { + bldr := array.NewDate64Builder(memory.DefaultAllocator) + defer bldr.Release() + + jsonstr := `["1970-01-02", null, "2286-11-20"]` + + bldr.AppendValues([]arrow.Date64{86400000, 0, 9999936000000}, []bool{true, false, true}) + expected := bldr.NewArray() + defer expected.Release() + + arr, _, err := array.FromJSON(memory.DefaultAllocator, arrow.FixedWidthTypes.Date64, strings.NewReader(jsonstr)) + assert.NoError(t, err) + defer arr.Release() + + assert.Truef(t, array.ArrayEqual(expected, arr), "expected: %s\ngot: %s\n", expected, arr) + + data, err := json.Marshal(arr) + assert.NoError(t, err) + assert.JSONEq(t, jsonstr, string(data)) + }) +} + +func TestTimeJSON(t *testing.T) { + tententen := 60*(60*(10)+10) + 10 + tests := []struct { + dt arrow.DataType + jsonstr string + valueadd int + }{ + {arrow.FixedWidthTypes.Time32s, `[null, "10:10:10"]`, 123}, + {arrow.FixedWidthTypes.Time32ms, `[null, "10:10:10.123"]`, 456}, Review comment: Right, that's the difference between using 0's or 9's in the format string. Using 0's will extend it to the exact precision stated, using 9's will truncate trailing zeros. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
