zeroshade commented on a change in pull request #11359:
URL: https://github.com/apache/arrow/pull/11359#discussion_r742850288
##########
File path: go/arrow/array/numeric.gen.go
##########
@@ -1085,6 +1377,22 @@ func (a *Duration) setData(data *Data) {
}
}
+func (a *Duration) getOneForMarshal(i int) interface{} {
+ if a.IsNull(i) {
+ return nil
+ }
+ return fmt.Sprint(time.Duration(a.values[i]) *
a.DataType().(*arrow.DurationType).Unit.Multiplier())
Review comment:
Yes, there can end up being overflow issues for large enough values
depending on the precision. I'll see if i can tweak this to try to avoid the
overflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
