pitrou commented on a change in pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#discussion_r744108374
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -4617,7 +4617,10 @@ const FunctionDoc binary_join_element_wise_doc(
"emit a null (the default), are skipped, or replaced with a given
string.\n"),
{"*strings"}, "JoinOptions");
-const auto kDefaultJoinOptions = JoinOptions::Defaults();
+static const JoinOptions* GetDefaultJoinOptions() {
Review comment:
These should be in the anonymous namespace already, so `static` is
probably superfluous.
(same for other occurrences below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
