pitrou commented on a change in pull request #11633:
URL: https://github.com/apache/arrow/pull/11633#discussion_r744108614
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -1153,7 +1153,10 @@ class TableSorter {
// ----------------------------------------------------------------------
// Top-level sort functions
-const auto kDefaultSortOptions = SortOptions::Defaults();
+static const ArraySortOptions* GetDefaultArraySortOptions() {
+ static const auto kDefaultArraySortOptions = ArraySortOptions::Defaults();
Review comment:
1) You're getting a redeclared identifier because of
`GetDefaultArraySortOptions` in unity builds (see e.g. AppVeyor failure)
2) This should be `SortOptions`, not `ArraySortOptions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
