houqp commented on a change in pull request #1259:
URL: https://github.com/apache/arrow-datafusion/pull/1259#discussion_r744178530
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -195,26 +195,42 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
} => {
let left_plan = self.set_expr_to_plan(left.as_ref(), None,
ctes)?;
let right_plan = self.set_expr_to_plan(right.as_ref(), None,
ctes)?;
+ let join_keys = left_plan
Review comment:
i am a bit concerned about the extra overhead here for the union
branches. perhaps also relevant to
https://github.com/apache/arrow-datafusion/pull/1258/files#r744178212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
