Dandandan commented on a change in pull request #1259:
URL: https://github.com/apache/arrow-datafusion/pull/1259#discussion_r744298064
##########
File path: datafusion/tests/sql.rs
##########
@@ -5669,3 +5669,67 @@ async fn test_intersect_distinct() -> Result<()> {
assert_batches_eq!(expected, &actual);
Ok(())
}
+
+#[tokio::test]
+async fn except_with_null_not_equal() {
+ let sql = "SELECT * FROM (SELECT null AS id1, 1 AS id2) t1
+ EXCEPT SELECT * FROM (SELECT null AS id1, 2 AS id2) t2";
+
+ let expected: Vec<Vec<String>> = vec![vec!["NULL".to_string(),
"1".to_string()]];
Review comment:
Using `&str` is possible here too I think, maybe easier to remove the
explicit type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
