jonkeane commented on a change in pull request #11644:
URL: https://github.com/apache/arrow/pull/11644#discussion_r746961918
##########
File path: r/vignettes/developing.Rmd
##########
@@ -154,15 +184,18 @@ You'll first call `cmake` to configure the build and then
`make install`. For th
```{bash, save=run & !sys_install}
cmake \
+ -G Ninja \
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_INSTALL_LIBDIR=lib \
+ -DARROW_BUILD_SHARED=OFF \
+ -DARROW_BUILD_STATIC=ON \
-DARROW_COMPUTE=ON \
-DARROW_CSV=ON \
-DARROW_DATASET=ON \
-DARROW_EXTRA_ERROR_CONTEXT=ON \
-DARROW_FILESYSTEM=ON \
-DARROW_INSTALL_NAME_RPATH=OFF \
- -DARROW_JEMALLOC=ON \
+ -DARROW_JEMALLOC=OFF \
Review comment:
Yup, the defaults are (on not-macos): jemalloc, mimalloc, system (in
that order, if they are available)
On macos: mimalloc, jemalloc, system (in that order, if they are available)
So on windows (if jemalloc isn't supported) the order will be: mimalloc,
system (in that order)
Because of this, I think we _do_ want it here at least when building on
linux or macos. Does it fail gracefully if it's `ON` on windows or does it
error completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
