wjones127 commented on a change in pull request #11644:
URL: https://github.com/apache/arrow/pull/11644#discussion_r746964769
##########
File path: r/vignettes/developing.Rmd
##########
@@ -154,15 +184,18 @@ You'll first call `cmake` to configure the build and then
`make install`. For th
```{bash, save=run & !sys_install}
cmake \
+ -G Ninja \
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_INSTALL_LIBDIR=lib \
+ -DARROW_BUILD_SHARED=OFF \
+ -DARROW_BUILD_STATIC=ON \
-DARROW_COMPUTE=ON \
-DARROW_CSV=ON \
-DARROW_DATASET=ON \
-DARROW_EXTRA_ERROR_CONTEXT=ON \
-DARROW_FILESYSTEM=ON \
-DARROW_INSTALL_NAME_RPATH=OFF \
- -DARROW_JEMALLOC=ON \
+ -DARROW_JEMALLOC=OFF \
Review comment:
It doesn't currently fail gracefully; it attempts to build jemalloc on
Windows and fails. I spent a good part of a day thinking my Arrow build broken
until I realized jemalloc just isn't supported on Windows 😢.
I can make a bolded note here that jemalloc should be off for Windows. And
then I'd like add something to CMake (or perhaps elsewhere) to not let you try
to build jemalloc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
