kou commented on a change in pull request #11689:
URL: https://github.com/apache/arrow/pull/11689#discussion_r748553991
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
Review comment:
```suggestion
"description": "Debug configuration with basic build",
```
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
Review comment:
Could you sort variable names in alphabetical order?
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
+ "type": "String",
+ "value": "Debug"
+ },
+ "ARROW_WITH_RE2": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_COMPUTE": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_CSV": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_FILESYSTEM": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_PYTHON": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_IPC": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_DATASET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_SKYHOOK": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_CUDA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PARQUET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PLASMA_JAVA_CLIENT": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JAVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JNI": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_BUILD_TESTS": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_BUILD_BENCHMARKS": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "CMAKE_INSTALL_PREFIX": {
+ "type": "PATH",
+ "value": "${sourceDir}/build/${presetName}/pkg"
+ }
+ }
+ },
+ {
+ "name": "ninja-debug-gandiva",
+ "description": "Builds gandiva libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_GANDIVA": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-skyhook",
+ "description": "Builds Skyhook libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_SKYHOOK": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-dataset",
+ "description": "Builds Arrow Dataset Modules along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_DATASET": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-parquet",
+ "description": "Builds Parquet libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_PARQUET": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-cuda",
+ "description": "Debug Arrow build with CUDA extensions (requires CUDA
toolkit)",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_CUDA": "ON"
+ }
+ },
+ {
+ "name": "ninja-release",
+ "description": "Release Configuration",
Review comment:
```suggestion
"description": "Release configuration",
```
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
+ "type": "String",
+ "value": "Debug"
+ },
+ "ARROW_WITH_RE2": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_COMPUTE": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_CSV": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_FILESYSTEM": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_PYTHON": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_IPC": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_DATASET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_SKYHOOK": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_CUDA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PARQUET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PLASMA_JAVA_CLIENT": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JAVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JNI": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_BUILD_TESTS": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_BUILD_BENCHMARKS": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "CMAKE_INSTALL_PREFIX": {
+ "type": "PATH",
+ "value": "${sourceDir}/build/${presetName}/pkg"
+ }
+ }
+ },
+ {
+ "name": "ninja-debug-gandiva",
+ "description": "Builds gandiva libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_GANDIVA": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-skyhook",
+ "description": "Builds Skyhook libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_SKYHOOK": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-dataset",
+ "description": "Builds Arrow Dataset Modules along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_DATASET": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-parquet",
+ "description": "Builds Parquet libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_PARQUET": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-cuda",
+ "description": "Debug Arrow build with CUDA extensions (requires CUDA
toolkit)",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_CUDA": "ON"
+ }
+ },
+ {
+ "name": "ninja-release",
+ "description": "Release Configuration",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": "Release",
+ "ARROW_GANDIVA": "ON",
+ "ARROW_PARQUET": "ON"
+ }
+ },
+ {
+ "name": "ninja-benchmarks",
+ "description": "Build for benchmarks with Ninja Generator",
Review comment:
```suggestion
"description": "Build for benchmarks",
```
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
+ "type": "String",
+ "value": "Debug"
+ },
+ "ARROW_WITH_RE2": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_COMPUTE": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_CSV": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_FILESYSTEM": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_PYTHON": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_IPC": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_DATASET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_SKYHOOK": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_CUDA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PARQUET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PLASMA_JAVA_CLIENT": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JAVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JNI": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_BUILD_TESTS": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_BUILD_BENCHMARKS": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "CMAKE_INSTALL_PREFIX": {
+ "type": "PATH",
+ "value": "${sourceDir}/build/${presetName}/pkg"
+ }
+ }
+ },
+ {
+ "name": "ninja-debug-gandiva",
+ "description": "Builds gandiva libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_GANDIVA": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-skyhook",
+ "description": "Builds Skyhook libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_SKYHOOK": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-dataset",
+ "description": "Builds Arrow Dataset Modules along with arrow",
Review comment:
```suggestion
"description": "Builds Arrow Dataset modules",
```
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
+ "type": "String",
+ "value": "Debug"
+ },
+ "ARROW_WITH_RE2": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_COMPUTE": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_CSV": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_FILESYSTEM": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_PYTHON": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_IPC": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_DATASET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_SKYHOOK": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_CUDA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PARQUET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PLASMA_JAVA_CLIENT": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JAVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JNI": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_BUILD_TESTS": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_BUILD_BENCHMARKS": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "CMAKE_INSTALL_PREFIX": {
+ "type": "PATH",
+ "value": "${sourceDir}/build/${presetName}/pkg"
+ }
+ }
+ },
+ {
+ "name": "ninja-debug-gandiva",
+ "description": "Builds gandiva libraries along with arrow",
Review comment:
```suggestion
"description": "Builds Gandiva libraries",
```
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
+ "type": "String",
+ "value": "Debug"
+ },
+ "ARROW_WITH_RE2": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_COMPUTE": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_CSV": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_FILESYSTEM": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_PYTHON": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_IPC": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_DATASET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_SKYHOOK": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_CUDA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PARQUET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PLASMA_JAVA_CLIENT": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JAVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JNI": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_BUILD_TESTS": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_BUILD_BENCHMARKS": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "CMAKE_INSTALL_PREFIX": {
+ "type": "PATH",
+ "value": "${sourceDir}/build/${presetName}/pkg"
+ }
+ }
+ },
+ {
+ "name": "ninja-debug-gandiva",
+ "description": "Builds gandiva libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_GANDIVA": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-skyhook",
+ "description": "Builds Skyhook libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_SKYHOOK": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-dataset",
+ "description": "Builds Arrow Dataset Modules along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_DATASET": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-parquet",
+ "description": "Builds Parquet libraries along with arrow",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_PARQUET": "ON"
+ }
+ },
+ {
+ "name": "ninja-debug-cuda",
+ "description": "Debug Arrow build with CUDA extensions (requires CUDA
toolkit)",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "ARROW_CUDA": "ON"
+ }
+ },
+ {
+ "name": "ninja-release",
+ "description": "Release Configuration",
+ "inherits": "ninja-debug",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": "Release",
+ "ARROW_GANDIVA": "ON",
+ "ARROW_PARQUET": "ON"
Review comment:
How about defining `ninja-release-gandiva` and `ninja-release`parquet`
for them instead of overwriting here?
##########
File path: cpp/CMakePresets.json
##########
@@ -0,0 +1,150 @@
+{
+ "version": 2,
+ "cmakeMinimumRequired": {
+ "major": 3,
+ "minor": 20,
+ "patch": 0
+ },
+ "configurePresets": [
+ {
+ "name": "ninja-debug",
+ "description": "Debug configuration with basic arrow build",
+ "binaryDir": "${sourceDir}/build/${presetName}",
+ "generator": "Ninja",
+ "cacheVariables": {
+ "CMAKE_BUILD_TYPE": {
+ "type": "String",
+ "value": "Debug"
+ },
+ "ARROW_WITH_RE2": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_COMPUTE": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_CSV": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_FILESYSTEM": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_PYTHON": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_IPC": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_DATASET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_SKYHOOK": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_CUDA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PARQUET": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_PLASMA_JAVA_CLIENT": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JAVA": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_GANDIVA_JNI": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "ARROW_BUILD_TESTS": {
+ "type": "BOOL",
+ "value": "ON"
+ },
+ "ARROW_BUILD_BENCHMARKS": {
+ "type": "BOOL",
+ "value": "OFF"
+ },
+ "CMAKE_INSTALL_PREFIX": {
+ "type": "PATH",
+ "value": "${sourceDir}/build/${presetName}/pkg"
+ }
+ }
+ },
+ {
+ "name": "ninja-debug-gandiva",
+ "description": "Builds gandiva libraries along with arrow",
Review comment:
Or:
```suggestion
"description": "Builds Gandiva libraries along with Arrow",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
