lidavidm commented on a change in pull request #11704:
URL: https://github.com/apache/arrow/pull/11704#discussion_r750277344
##########
File path: cpp/src/arrow/type.h
##########
@@ -1657,6 +1657,11 @@ class ARROW_EXPORT FieldRef {
const std::string* name() const {
return IsName() ? &util::get<std::string>(impl_) : NULLPTR;
}
+ const std::vector<FieldRef>* nested_refs() const {
+ return util::holds_alternative<std::vector<FieldRef>>(impl_)
+ ? &util::get<std::vector<FieldRef>>(impl_)
+ : NULLPTR;
+ }
Review comment:
Ah, this is because IsNested is checking whether it's either a FieldPath
or a series of Names, but this accessor only wants the latter case. (I think
the IsNested naming is a little unfortunate…)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
