zeroshade commented on a change in pull request #11712:
URL: https://github.com/apache/arrow/pull/11712#discussion_r750484716
##########
File path: go/arrow/ipc/message.go
##########
@@ -154,11 +154,18 @@ type messageReader struct {
refCount int64
msg *Message
+
+ mem memory.Allocator
}
// NewMessageReader returns a reader that reads messages from an input stream.
-func NewMessageReader(r io.Reader) MessageReader {
- return &messageReader{r: r, refCount: 1}
+func NewMessageReader(r io.Reader, opts ...Option) MessageReader {
Review comment:
You're right about avoiding breaking with the options. Though I
personally doubt many people are calling `NewMessageReader` directly, it's
really only exported because the `flight` package uses it to sit on top of the
ipc readers to provide access to the additional metadata in flight messages.
It's not a big issue either way I think. More of an aesthetic thing where
this gives the impression that message reader would work with other options
that get ignored like the reader is doing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
