zeroshade commented on pull request #11712: URL: https://github.com/apache/arrow/pull/11712#issuecomment-970479777
Honestly, looking at this and now that I think of it. It looks like the readers actually call `bytes.NewReader` on the buffer that was already created in the message reader. As a result, it looks like we're currently actually copying no matter what which sucks, but makes it easy to stick the allocator in there. Optimally, we'd do what you've done here with the allocator in the message reader for the body, and then just pass slices of this buffer when creating the records. Though that would probably be beyond the scope of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
