viirya opened a new pull request #1319:
URL: https://github.com/apache/arrow-datafusion/pull/1319
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #1316.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This patch fixes a bug happened when users construct an aggregate function
which has constants that can be folded.
As in projection pushdown rule, we check if an expression output (e.g., an
aggregate function) is required by above plan (e.g. a projection) by comparing
expression's name. But after constant folding rule, it is likely that the name
of an aggregate function is changed (e.g., from `COUNT(1 + 1)` to `COUNT(2)`).
Changed aggregate function is removed as we wrongly think it as unnecessary
expression as the top projection requires `#COUNT(1 + 1)`, not `#COUNT(2)`.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Moving `ConstantFolding` optimizer rules to the end.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Should be not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
