viirya commented on a change in pull request #1319:
URL: https://github.com/apache/arrow-datafusion/pull/1319#discussion_r752636483
##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -101,7 +105,30 @@ impl OptimizerRule for ConstantFolding {
// fold constants and then simplify
.rewrite(&mut const_evaluator)?
.rewrite(&mut simplifier)?;
- Ok(new_e)
+
+ let new_name = &new_e.name(plan.schema());
+
+ // Some plans will be candidates in projection
pushdown rule to
+ // trim expressions based on expression names. We need
to keep
+ // expression name for them.
+ let is_plan_for_projection_pushdown = matches!(
+ plan,
+ LogicalPlan::Window { .. }
Review comment:
For example, for Project, it will create many (looks redundant) aliases.
Some looks okay but some looks really weird, e.g. some failed tests:
```
Projection: #test.a, #test.d, NOT #test.b AS test.b = Boolean(false)
...
```
```
Projection: Int32(0) AS CAST(Utf8(\"0\") AS Int32)
...
```
We have a lot tests that would be failed due to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
