jonkeane commented on a change in pull request #11482:
URL: https://github.com/apache/arrow/pull/11482#discussion_r751431199
##########
File path: r/R/duckdb.R
##########
@@ -55,7 +55,7 @@
to_duckdb <- function(.data,
con = arrow_duck_connection(),
table_name = unique_arrow_tablename(),
- auto_disconnect = FALSE) {
+ auto_disconnect = TRUE) {
.data <- as_adq(.data)
duckdb::duckdb_register_arrow(con, table_name, .data)
Review comment:
There hasn't been any comments (positive or negative) on
https://github.com/tidyverse/dbplyr/issues/681
On the positive side: this is "just" an element of a list that stores an
object and we are relying on the way R cleans up objects when they are GCed, we
could name it anything and so long as d(b)plyr doesn't collide with that name
for something else it should _just work_ whether or not we are supposed to
extend `tbl$src$disco`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
