jonkeane commented on a change in pull request #11482:
URL: https://github.com/apache/arrow/pull/11482#discussion_r751541723
##########
File path: r/R/duckdb.R
##########
@@ -55,7 +55,7 @@
to_duckdb <- function(.data,
con = arrow_duck_connection(),
table_name = unique_arrow_tablename(),
- auto_disconnect = FALSE) {
+ auto_disconnect = TRUE) {
.data <- as_adq(.data)
duckdb::duckdb_register_arrow(con, table_name, .data)
Review comment:
_nods_ yes, totally could. I kept it in the "traditional" spot since
that's what dbplyr does, but maybe it would be better to proactively avoid any
possible collisions/changes in their API for that.
NGL, `disco` is a hilariously awesome name even if it isn't _super_
transparent 🕺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
