jgoday commented on a change in pull request #1330:
URL: https://github.com/apache/arrow-datafusion/pull/1330#discussion_r753663127
##########
File path: datafusion-cli/src/exec.rs
##########
@@ -84,15 +84,20 @@ pub async fn exec_from_repl(ctx: &mut Context,
print_options: &PrintOptions) {
rl.set_helper(Some(CliHelper::default()));
rl.load_history(".history").ok();
+ let mut print_options = print_options.clone();
+
loop {
match rl.readline("❯ ") {
Ok(line) if line.starts_with('\\') => {
rl.add_history_entry(line.trim_end());
if let Ok(cmd) = &line[1..].parse::<Command>() {
match cmd {
Command::Quit => break,
+ Command::QuietMode(quiet) => {
Review comment:
Fair question, but I did not dare to change the Command::execute
signature (to make print_options mutable).
What do you think about that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
