Jimexist commented on a change in pull request #1330:
URL: https://github.com/apache/arrow-datafusion/pull/1330#discussion_r753660607
##########
File path: datafusion-cli/src/exec.rs
##########
@@ -84,15 +84,20 @@ pub async fn exec_from_repl(ctx: &mut Context,
print_options: &PrintOptions) {
rl.set_helper(Some(CliHelper::default()));
rl.load_history(".history").ok();
+ let mut print_options = print_options.clone();
+
loop {
match rl.readline("❯ ") {
Ok(line) if line.starts_with('\\') => {
rl.add_history_entry(line.trim_end());
if let Ok(cmd) = &line[1..].parse::<Command>() {
match cmd {
Command::Quit => break,
+ Command::QuietMode(quiet) => {
Review comment:
I wonder why not move the execution to the command file? quit should be
the only exception here?
##########
File path: datafusion-cli/src/exec.rs
##########
@@ -84,15 +84,20 @@ pub async fn exec_from_repl(ctx: &mut Context,
print_options: &PrintOptions) {
rl.set_helper(Some(CliHelper::default()));
rl.load_history(".history").ok();
+ let mut print_options = print_options.clone();
+
loop {
match rl.readline("❯ ") {
Ok(line) if line.starts_with('\\') => {
rl.add_history_entry(line.trim_end());
if let Ok(cmd) = &line[1..].parse::<Command>() {
match cmd {
Command::Quit => break,
+ Command::QuietMode(quiet) => {
Review comment:
I don't believe it's used outside this repo nor any downstream code so
you should feel free to change it as you see fit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
