jorisvandenbossche commented on a change in pull request #11724:
URL: https://github.com/apache/arrow/pull/11724#discussion_r754079247
##########
File path: python/pyarrow/_parquet.pyx
##########
@@ -1284,6 +1294,14 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
props.encoding(tobytes(column),
ParquetEncoding_BYTE_STREAM_SPLIT)
+ # col_encoding
+ # encoding map - encode individual columns
+
+ if col_encoding is not None:
+ for column, _encoding in col_encoding.items():
+ props.encoding(tobytes(column),
+ encoding_enum_from_name(_encoding))
Review comment:
Ah, yes, sorry :) That was indeed for unknown encoding, not unknown
column. If the underlying C++ code doesn't error for unknown columns, let's
maybe leave that for now as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
