AlenkaF commented on a change in pull request #11724:
URL: https://github.com/apache/arrow/pull/11724#discussion_r756863581
##########
File path: python/pyarrow/_parquet.pyx
##########
@@ -1278,11 +1297,43 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
if isinstance(use_byte_stream_split, bool):
if use_byte_stream_split:
- props.encoding(ParquetEncoding_BYTE_STREAM_SPLIT)
+ if column_encoding is not None:
+ raise ValueError(
+ "'column_encoding' is not None")
Review comment:
The reason behind all these conflicts is that `use_byte_stream_split`
encoding is same as `BYTE_STREAM_SPLIT` column encoding option. To catch
situations when both are specified, I added this checks.
I could change the error msg to "`use_byte_stream_split` can not be passed
together with `column_encoding`" or maybe remove `use_byte_stream_split`
altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
