paleolimbot commented on a change in pull request #11690:
URL: https://github.com/apache/arrow/pull/11690#discussion_r755445815
##########
File path: r/R/dplyr-functions.R
##########
@@ -250,6 +250,39 @@ nse_funcs$is_logical <- function(x, n = NULL) {
nse_funcs$is.logical(x)
}
+# Create a data frame/tibble/struct column
+nse_funcs$tibble <- function(..., .rows = NULL, .name_repair = NULL) {
+ if (!is.null(.rows)) arrow_not_supported(".rows")
+ if (!is.null(.name_repair)) arrow_not_supported(".name_repair")
Review comment:
I'd argue that if somebody is using `.name_repair`, `.rows`,
`check.names`, `row.names`, or `fix.empty.names`, they are going to get
something they didn't intend when passing it to `make_struct()`. For example,
the main reason to include `.rows` is to allow creating a zero-column data
frame (which make_struct doesn't support). Is there a particular use-case you
had in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
