paleolimbot commented on a change in pull request #11690:
URL: https://github.com/apache/arrow/pull/11690#discussion_r755600769
##########
File path: r/R/dplyr-functions.R
##########
@@ -250,6 +250,60 @@ nse_funcs$is_logical <- function(x, n = NULL) {
nse_funcs$is.logical(x)
}
+# Create a data frame/tibble/struct column
+nse_funcs$tibble <- function(..., .rows = NULL, .name_repair = NULL) {
+ if (!is.null(.rows)) arrow_not_supported(".rows")
+ if (!is.null(.name_repair)) arrow_not_supported(".name_repair")
+
+ # use dots_list() because this is what tibble() uses to allow the
+ # useful shorthand of tibble(col1, col2) -> tibble(col1 = col1, col2 = col2)
+ # we have a stronger enforcement of unique names for arguments because
+ # it is difficult to replicate the .name_repair semantics and expanding of
+ # unnamed data frame arguments in the same way that the tibble() constructor
+ # does.
+ args <- rlang::dots_list(..., .named = TRUE, .homonyms = "error")
+
+ build_expr(
+ "make_struct",
+ args = unname(args),
+ options = list(field_names = names(args))
+ )
+}
+
+nse_funcs$data.frame <- function(..., row.names = NULL,
+ check.rows = NULL, check.names = TRUE,
fix.empty.names = TRUE,
+ stringsAsFactors = FALSE) {
+ # we need a specific value of stringsAsFactors because the default was
+ # TRUE in R <= 3.6
+ if (!identical(stringsAsFactors, FALSE)) {
+ arrow_not_supported("stringsAsFactors = TRUE")
+ }
+
+ # ignore row.names and check.rows with a warning
Review comment:
I think we have to handle `check.names` and `stringsAsFactors` because
the default values are not ideal...I think I'd prefer to error if the user
passes any of the others (an earlier version of this PR did), but I also think
the arguments are rare in this context and both a warning and a stop
communicate the same idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
