matthewmturner commented on a change in pull request #975:
URL: https://github.com/apache/arrow-rs/pull/975#discussion_r756548825
##########
File path: arrow/src/util/pretty.rs
##########
@@ -42,6 +43,12 @@ pub fn print_batches(results: &[RecordBatch]) -> Result<()> {
Ok(())
}
+pub fn write_batches<W: Write>(buf: &mut W, results: &[RecordBatch]) ->
Result<()> {
Review comment:
@alamb thanks for comment - that actually got me thinking about this
differently.
first, couldnt we just do:
`write!(&mut buf, "{}", pretty_format_batches(batches))`
if so, im not even sure this PR is needed?
second, assuming that doesnt work could you just explain what the difference
is between `pretty_format_batches` and the `displayable` function you proposed?
@Jimexist what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
