alamb commented on a change in pull request #975:
URL: https://github.com/apache/arrow-rs/pull/975#discussion_r757883853



##########
File path: arrow/src/util/pretty.rs
##########
@@ -42,6 +43,12 @@ pub fn print_batches(results: &[RecordBatch]) -> Result<()> {
     Ok(())
 }
 
+pub fn write_batches<W: Write>(buf: &mut W, results: &[RecordBatch]) -> 
Result<()> {

Review comment:
       > And just to confirm, is the reason to return a type that implements 
Display instead of the Table or Column from comfy_table to give us more 
flexibility around that in the future?
   
   Yes, I think so -- for example when we updated from `pretty-table` to 
`comfy-table` or upgraded versions of `comfy-table` the `arrow` API wouldn't 
change




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to