thisisnic commented on pull request #11790: URL: https://github.com/apache/arrow/pull/11790#issuecomment-981569260
> I think `decimal256()` is a bit more involved (not yet surfaced from C++). Hence the intention to implement them in 2 separate PRs. For `decimal128()` we didn't have to add a binding. It was merely a matter of porting the code for `decimal()`. That's fair enough! > Do we need to change this to point to DECIMAL128? I think so - I took a look at how `TimeType` + `Time32` + `Time64` are all implemented here and in `arrow/r/R/type.R` to try to work this out. I also found potential changes needed to the function `nse_funcs$is.numeric()`, and there's also this which could need updating: https://github.com/apache/arrow/blob/236362aaf5bdee0eb88da5048eeda174182ef508/r/R/enums.R#L68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
