lidavidm commented on a change in pull request #11798:
URL: https://github.com/apache/arrow/pull/11798#discussion_r759292226
##########
File path: cpp/src/arrow/compute/kernels/util_internal.h
##########
@@ -23,8 +23,11 @@
#include "arrow/array/util.h"
#include "arrow/buffer.h"
+#include "arrow/chunked_array.h"
#include "arrow/compute/kernels/codegen_internal.h"
#include "arrow/compute/type_fwd.h"
+#include "arrow/record_batch.h"
+#include "arrow/table.h"
Review comment:
nit: I think we should be able to forward-declare
Array/RecordBatch/Table instead of including the headers (or include
`arrow/type_fwd.h`), which would cut down on the headers that get
(transitively) included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
